Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Toggle): disabled color tokens #10059

Merged
merged 2 commits into from
Nov 9, 2021
Merged

fix(Toggle): disabled color tokens #10059

merged 2 commits into from
Nov 9, 2021

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Nov 5, 2021 •
edited
Loading

Closes #9750

Changelog

Screen Shot 2021-11-05 at 11 25 36 AM

Testing / Reviewing

  • open v10 react deploy preview > test toggle playground story > check disabled > check that it works for all themes
    note for dev reviewers: the v11 styles package is using the correct v11 tokens, so no need to update there

@jnm2377 jnm2377 requested a review from a team as a code owner November 5, 2021 17:11
@jnm2377 jnm2377 requested review from abbeyhrt and dakahn November 5, 2021 17:11
@netlify
Copy link

netlify bot commented Nov 5, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: cbcbe7d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6189b4731a56790007524b4e

😎 Browse the preview: https://deploy-preview-10059--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Nov 5, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: cbcbe7d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6189b473712cfb000865c733

😎 Browse the preview: https://deploy-preview-10059--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Nov 5, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: cbcbe7d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6189b47301d89a0007881a5d

😎 Browse the preview: https://deploy-preview-10059--carbon-components-react.netlify.app

@abbeyhrt
Copy link
Contributor

abbeyhrt commented Nov 5, 2021

@jnm2377 Do you happen to have a screenshot of what the toggle should look like now with the new tokens?

@jnm2377
Copy link
Contributor Author

jnm2377 commented Nov 5, 2021

@abbeyhrt oh, there's a picture included in the old issue that was originally fixed: #6794 (comment)

@jnm2377 jnm2377 requested a review from aagonzales November 5, 2021 18:43
abbeyhrt
abbeyhrt approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me!

aagonzales
aagonzales approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo-hoo! You figured it out!

dakahn
dakahn approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@jnm2377 jnm2377 enabled auto-merge (squash) November 9, 2021 21:07
@jnm2377 jnm2377 merged commit 902eefa into carbon-design-system:main Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@aagonzales aagonzales aagonzales approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Toggle] Text when Disabled does not provide enough contrast and is difficult to read
4 participants
@jnm2377 @abbeyhrt @aagonzales @dakahn